Skip to content

Hacktoberfest: adding doctest to radix_sort.py file #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2020
Merged

Hacktoberfest: adding doctest to radix_sort.py file #2779

merged 8 commits into from
Oct 29, 2020

Conversation

mvhb
Copy link
Contributor

@mvhb mvhb commented Oct 4, 2020 •
edited
Loading

Describe your change:

I added a doctest to an existing file (radix_sort.py)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mvhb mvhb changed the title adding doctest to radix_sort.py file Hacktoberfest: adding doctest to radix_sort.py file Oct 7, 2020
@mvhb mvhb mentioned this pull request Oct 7, 2020
Closed
2 tasks
@poyea poyea requested a review from l3str4nge as a code owner October 29, 2020 00:41
@TravisBuddy
Copy link

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 432700f0-1980-11eb-a6ec-b9eb403ed3be

@TravisBuddy
Copy link

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 786d2820-1980-11eb-a6ec-b9eb403ed3be

@TravisBuddy
Copy link

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 335ba8e0-1982-11eb-a6ec-b9eb403ed3be

@poyea poyea merged commit a1e9656 into TheAlgorithms:master Oct 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mvhb @poyea @stokhos
Hacktoberfest: adding doctest to radix_sort.py file (TheAlgorithms#2779)
cbafcd1 
* adding doctest to radix_sort.py file

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* Update radix_sort.py

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* line

* fix tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@mvhb @poyea @peRFectBeliever
Hacktoberfest: adding doctest to radix_sort.py file (TheAlgorithms#2779)
0ff3f32 
* adding doctest to radix_sort.py file

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* Update radix_sort.py

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* line

* fix tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@mvhb @poyea
Hacktoberfest: adding doctest to radix_sort.py file (TheAlgorithms#2779)
9dad46d 
* adding doctest to radix_sort.py file

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* Update radix_sort.py

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* line

* fix tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@mvhb @poyea @shermanhui
Hacktoberfest: adding doctest to radix_sort.py file (TheAlgorithms#2779)
a4a34f0 
* adding doctest to radix_sort.py file

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* Update radix_sort.py

* fixup! Format Python code with psf/black push

* Update radix_sort.py

* line

* fix tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@kbakdev kbakdev kbakdev approved these changes

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvhb @TravisBuddy @poyea @kbakdev